Remove reliance on FitbitAppCredentials in the FitbitClient.#2
Open
WestDiscGolf wants to merge 1 commit into
Open
Remove reliance on FitbitAppCredentials in the FitbitClient.#2WestDiscGolf wants to merge 1 commit into
WestDiscGolf wants to merge 1 commit into
Conversation
…y used by the DefaultTokenManager so moved it to it's constructor. Nothing should require a dependency if only being used by something else! Removed the unrequired constructor overloads which were originally to aid upgrading from v1 to v2. With optional parameters these are no longer required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's only used by the DefaultTokenManager so moved it to it's constructor.
Nothing should require a dependency if only being used by something else!
Removed the unrequired constructor overloads which were originally to aid upgrading from v1 to v2. With optional parameters these are no longer required.